AutoSPSourceBuilder
AutoSPSourceBuilder copied to clipboard
brianlala
OWA Did not extract
First, great script system! Everything downloaded aok. Got an error extracting OWA CU path files. Could not find the file or path, line 702: char 13. Sept 2016 CU for OWA (SharePoint 2013).
Any help or workarounds appreciated. Thank you!
Same issue here, I guess. OOS 2019, October 2021 patch. Script version 2.0.3.0.
The issue is with a logic that was applicable for early OWA 2013 and 2010 patches, which were ZIP files with EXE extension. The script simply adds .ZIP extension and then runs a custom Expand-Zip function on it. Expand-Zip function fails to extract anything, because the file is not a proper ZIP archive, and it fails silently. Then, on the next step script tries to slipstream content of patch file into OOS installation folder. This fails with error mentioned by @beldara, except it's now at line 951 char:13. It tries to extract from .EXE patch file, but the file has .ZIP extension at this point.
Solution, I guess, would be to treat OWA 2013 patches after August 2014 and all 2016/2019 differently - there is no need to work with ZIP in this case. OWA 2010 is a bit more tricky since MS didn't just stop releasing "ZIP-renamed-to-EXE" files after certain patch.
edit1: I realized this mess applies to OWA 2010 as well.
Pull request #11 has a fix for this. @brianlala, do you think you can review and merge it anytime soon?
It will take me some time to review as the original PR is over 5 years old now and code has changed significantly since then (I can't even do a compare because it thinks the .ps1 is a binary file). I'm on vacation currently and will revisit next week.