proxy-audio-device icon indicating copy to clipboard operation
proxy-audio-device copied to clipboard

Support for installating with Homebrew

Open Odame opened this issue 3 years ago • 8 comments

Feature Request

This is a great piece of software - nice job done ✌🏾. In addition to the existing coolness, it will be nice if this application supports installation via homebrew.

Odame avatar Aug 10 '21 15:08 Odame

I've never packaged up an app for installation via Homebrew before. This app might make more sense for homebrew cask, but I'm not sure. I may get around to it eventually, but if someone else wants to set that up, I'm happy to assist by doing whatever work is necessary on my end.

briankendall avatar Aug 10 '21 17:08 briankendall

Yeah, a homebrew cask is definitely the right way to go in that regard. I too, don't have experience with packaging for Homebrew. But I will take a look at homebrew and see if I can pull this off - unless someone else with prior experience wants to take this up.

Odame avatar Aug 11 '21 04:08 Odame

I also like the homebrew approach, as it is the more modern and most popular way nowadays.

MartinMajewski avatar Mar 16 '23 10:03 MartinMajewski

Btw, looks like this just got added to homebrew-cask now: https://github.com/Homebrew/homebrew-cask/pull/155006

It seems to just install the .app though, and not the driver (nor does it kickstart coreaudiod). Seems there are probably some helpers that could be added to the cask to make it work, although they seem to be missing one for Audio/Plug-Ins/HAL. I don't have much experience either but maybe @chenrui333 knows what to do since they opened the original PR.

ian-h-chamberlain avatar Sep 18 '23 19:09 ian-h-chamberlain

I've been bitten by the issue @ian-h-chamberlain mentioned, the cask does not install the driver at all.

Downloading the release and copying over the driver manually does work, maybe the readme needs to mention this?

mahmoudhossam avatar Nov 22 '23 14:11 mahmoudhossam

https://github.com/Homebrew/homebrew-cask/pull/162690 has just been merged, which I believe should fix this issue (I think auto-close didn't work since it's in a different repo). It would be great if some other people could test it and verify the fix, after which I think this issue can be closed?

ian-h-chamberlain avatar Dec 17 '23 00:12 ian-h-chamberlain

I tried it today and it seems to do the right thing on my system.

I'd prefer if it gave more details on this Changing ownership of paths required by proxy-audio-device with sudo; the password may be necessary. as first-time installers might not have the necessary permissions set already.

mahmoudhossam avatar Dec 18 '23 09:12 mahmoudhossam

That message comes from brew itself, but you can see more details about what it's doing with --verbose --debug:

==> Changing ownership of paths required by proxy-audio-device with sudo; the password may be necessary.
/usr/bin/sudo -E -- /usr/sbin/chown -R -- root:wheel /Library/Audio/Plug-Ins/HAL/ProxyAudioDevice.driver
/usr/bin/sudo -E -- /bin/launchctl kickstart -k system/com.apple.audio.coreaudiod
==> Installing artifact of class Cask::Artifact::PostflightBlock
🍺  proxy-audio-device was successfully installed!

@Odame or @briankendall it seems like this is fixed now, would one of you like to close the issue?

ian-h-chamberlain avatar Dec 18 '23 13:12 ian-h-chamberlain