Brian J. Murrell

Results 537 comments of Brian J. Murrell

Indeed. That was the other side effect I forgot to mention.

Yeah, that script doesn't quite seem to do what I want. For one thing it seems to assume the "thing" you want to compress is all of the files in...

> grom72 (Tomasz Gromadzki) force-pushed the grom72/trivy branch from 34df04c to b7277dd @grom72 We don't allow force-pushing once reviewing has started as it voids the ability to incrementally review only...

Is there any reason we are not using the https://github.com/aquasecurity/trivy-action github action, possibly/potentially with [GitHub Code Scanning](https://docs.github.com/en/code-security/code-scanning/introduction-to-code-scanning/about-code-scanning)?

> It is because of not signed merge commits In the future you can disregard issues with unsigned merge commits. They will disappear when the PR is landed. > and...

> > Is there any reason we are not using the [aquasecurity/trivy-action](https://github.com/aquasecurity/trivy-action) github action, possibly/potentially with [GitHub Code Scanning](https://docs.github.com/en/code-security/code-scanning/introduction-to-code-scanning/about-code-scanning)? > > The reason was/is to have easy local reproduction of...

Not trying to be snarky or anything of the sort @ShootingKing-AM but why not just use https://github.com/marketplace/actions/test-reporting rather than this action? Just asking because I agree with you on the...

Maybe [this one](http://brian.interlinx.bc.ca/linphone-contact-edit-failure2.txt)?

Guest nets (or any other kinds of VLANS) is one use case. VPNs subnets are another. Maybe you want to treat your VPNs with the same policy as your LAN...

And the problem is here https://github.com/AlmaLinux/leapp-repository/blob/249925a3180b325a2eba40c06486c46d7d9eded8/repos/system_upgrade/common/actors/checknfs/actor.py#L33-L38 But this exact issue was [reported upstream ](https://github.com/oamg/leapp-repository/issues/807) over 2 years ago! And it was [fixed](https://github.com/oamg/leapp-repository/pull/888/files) upstream [over two years ago](https://github.com/AlmaLinux/leapp-repository/commit/184dc7be352e5f23d5f85fadb681ddc839dfffbe). So why are...