drf_orjson_renderer icon indicating copy to clipboard operation
drf_orjson_renderer copied to clipboard

Remove upper limit on pinned django version, only keep Django>=3.2

Open sidmitra opened this issue 2 years ago • 3 comments

Instead of creating a periodic pull request for each minor Django version, perhaps only pinning the lower limit is a better tradeoff.

Related PRs

  • https://github.com/brianjbuck/drf_orjson_renderer/pull/16
  • https://github.com/brianjbuck/drf_orjson_renderer/pull/14

sidmitra avatar Mar 23 '22 01:03 sidmitra

@brianjbuck Let me know if you think we should add a test with various django versions? Or atleast include the "latest" one on pypi. This might help get ahead of the problem of broken compatibility in the future, in case some interface changes.

sidmitra avatar Mar 23 '22 01:03 sidmitra

Hey @brianjbuck , this seems like a very safe change to merge in, and will let people use your awesome library in Django 4.x without having without having to override the version resolver in tools like pip and poetry

kylebebak avatar Jun 07 '22 23:06 kylebebak

when will it be merged?

withthelemons avatar Aug 26 '22 18:08 withthelemons

+1 @brianjbuck :pray:

image

khamaileon avatar Oct 12 '22 23:10 khamaileon

@brianjbuck Can you merge this?

abreumatheus avatar Nov 06 '22 05:11 abreumatheus