drf_orjson_renderer icon indicating copy to clipboard operation
drf_orjson_renderer copied to clipboard

Pin django version to "<=4.1"

Open Zagrebelin opened this issue 3 years ago • 2 comments

"Django<=4.0" is very strict rule, 4.0.1 and other minor versions are not satisfied this requirement.

Zagrebelin avatar Jan 25 '22 11:01 Zagrebelin

@brianjbuck

This would be a great help, if you've got a bit of time to merge this PR and release a new version of orjson renderer that would be excellent

Btw @Zagrebelin, the version range also needs to be updated (in fact only needs to be updated) in setup.py

kylebebak avatar Mar 10 '22 04:03 kylebebak

@brianjbuck

My earlier PR got merged here. But i had a question there too

PS: Would it be ok to just specify the minimum version. i.e. >=3.2 ?

I reckon the related interface being used around DRF, Django is fairly stable, so we can get away with just pinning the minimum version i.e. >=3.2 In case there is a problem in the future, perhaps then we can decide to either fix or pin the higher/upper limit?

This way we might be able to avoid periodic tickets around each Django minor version upgrade.

~~I can send a PR if that works.~~ Sent a PR removing the upper limit here

sidmitra avatar Mar 23 '22 00:03 sidmitra