Brian Helba

Results 53 comments of Brian Helba

@danlamanna Let's review again, with an eye towards downstream use in the projects we know about.

@danlamanna Can you rebase this? It will be a little easier to think about with #278 in place.

Agreed, the README is woefully out of date, and needs to be updated, particularly following the major refactor which happened recently. Thanks for filing this issue to track progress. The...

This implements automatic request retry using a library, which is a lot less code for us to maintain. In some ways, this has slightly fewer features, but the behavior here...

@dchiquito Just to clarify, you tested these headers on both AWS S3 and MinIO?

[Codecov flags](https://docs.codecov.io/docs/flags) may be helpful here.

We should also investigate the behavior when `CompleteMultipartUpload` is called repeatedly (which could mistakenly happen due to retries).

In the short term, downstreams can reference this module via the repo: https://www.terraform.io/docs/modules/sources.html#github or https://www.terraform.io/docs/modules/sources.html#http-urls Longer term: https://www.terraform.io/docs/registry/modules/publish.html

Following some discussion with @danlamanna, I'm mostly convinced that there's no benefit to having any parallelization of part uploads. With small HTTP requests, for script files, API endpoints, etc., fetching...