Brian Gow

Results 42 comments of Brian Gow

Eventually we want to be able to embargo an open access project, as described in b. above. Until that is implemented, we want to prevent an embargo from being applied...

@greenstick , I apologize for the delay in responding. Thank you for you suggestion! I have opened a separate issue to indicate that we want to make our read and...

@greenstick , thanks! Yeah, `rdsamp` and `wrsamp` are definitely not isomorphic at this point. For example `rdsamp` does not have a variable which indicates what format the stored record you...

@tompollard , if this failing test is of concern, could you guide me on what to do to resolve it: ``` would reformat /home/runner/work/wfdb-python/wfdb-python/wfdb/io/record.py 2 files would be reformatted, 36...

> The following raises an error: > > ``` > >>> wfdb.wrsamp("xxx", fs=500, units=["mV"], sig_name=["I"], fmt=["16"], > e_p_signal=[numpy.array([0.0, 1.0, 2.0])], > adc_gain=[1.0], baseline=[0]) > TypeError: 'NoneType' object is not subscriptable...

> The following raises an error: > > ``` > >>> wfdb.wrsamp("xxx", fs=500, units=["mV"], sig_name=["I"], e_p_signal=[numpy.array([0.0, 1.0, 2.0])], fmt=["16"], samps_per_frame=[3]) > TypeError: ufunc 'isinf' not supported for the input types,...

@sanketahegde , the data provided by the hospital had multiple report columns - we are preserving this structure in the table your are referring to. I'm not a clinician but...

This looks great! Being able to select the signals you want to view is a nice feature. I had a few thoughts around potential improvements, none of which should be...

Just a few follow-up thoughts on some of the points @Lucas-Mc. Again, I don't think any of these should be taken as necessary for the initial release of this waveform...

@Lucas-Mc this update is much welcomed! When clicking Download All Items it was only downloading the first file for me. Also, is it possible to allow downloading individual folders (and...