rgbaster.js icon indicating copy to clipboard operation
rgbaster.js copied to clipboard

Published 20 hours ago • verified publisher icon briangonzalez

unpkg usage

Open a-hariti opened this issue 6 years ago • 5 comments

document CDN usage through upkg

a-hariti avatar Feb 04 '19 10:02 a-hariti

@a-hariti Looks like your PRs have some cross pollination of commits? Mind separating them out into distinct PRs?

Thanks!

briangonzalez avatar Feb 05 '19 00:02 briangonzalez

I'm afraid I don't get the meaning of "cross pollination of commits", but I will try to fix these issues. if you want to selectively merge commits, I suggest git cherry-pick

a-hariti avatar Feb 05 '19 09:02 a-hariti

I am just saying that you have two PRs, one called "unpkg" and one called "prettier", yet this commit (the one about "unpkg") had commits from the other PR.

If you can make sure each PR only has one concern, it'll make my job easier when it comes time to merge.

Thanks!

briangonzalez avatar Feb 05 '19 21:02 briangonzalez

I will be careful next time. sometimes I change branches and forget that I made a certain change elsewhere (and I don't have a very strong git fu [yet] to clean the mess :laughing:)

a-hariti avatar Feb 05 '19 23:02 a-hariti

Let me know if you'd like a hand :)

briangonzalez avatar Feb 05 '19 23:02 briangonzalez