Brian Egan

Results 79 comments of Brian Egan

I actually really like the idea behind this change. It's something I'd considered in the past as well! One question about the implementation that I'd love some feedback on: It...

Heya @lukepighetti -- how are ya feeling about this change?

One thing I was considering: I don't think most people want `shareValueSeeded` (from the Rx spec), which will shut down when there are no more listeners. Rather, I think most...

Good catch, thanks! @frankpepermans Should we just change the implementation to use the default transformers anyhow and remove the custom transformer?

Yep, @hoc081098 is exactly right: When you listen to the Stream, you can set `cancelOnError: true` and that should give you the behavior you're looking for!

@shinayser Ah, gotcha -- just as a heads up, that would go against the normal behavior for Dart Streams, which usually require the listener to define that behavior. If you're...

Yep, that's another way to go about it. If you were designing the api, what would it look like? `onErrorCancel([bool Function(dynamic err) shouldCancel])` kind of a thing? By default, it...

> (the word "close" is more expressive than "cancel", what you think?) Naming is hard :) I don't feel strongly one way or the other. I changed the issue to...

It's actually a really interesting question -- what does "Empty" mean in terms of Dart Streams. If an error is emitted, does that mean the Stream is no longer "empty"?...

Hey there -- thanks for contributing! Overall, I feel pretty strongly that we should not add this to the library. The Stream API is already quite large and hard for...