openweathermap icon indicating copy to clipboard operation
openweathermap copied to clipboard

Published 20 hours ago • verified publisher icon briandowns

*byzip should not use int as datatype

Open dragonchaser opened this issue 4 years ago • 1 comments

The ByZip functions require an int as argument, this is an issue with German zip codes since they can start with a 0, for example Chemnitz (Saxony) has the zip acode 09123

Examples of functions affected:

  • func (w *CurrentWeatherData) CurrentByZip(zip int, countryCode string) error (current.go)
  • func (f *ForecastWeatherData) DailyByZip(zip int, countryCode string, days int) (forecast.go)

I suggest passing this as string

dragonchaser avatar Feb 02 '21 15:02 dragonchaser

United States zip codes can start with a 0 as well. I came here to open an issue, but you beat me to it by two days.

Zip codes around Atlantic City for instance:

image

donatj avatar Feb 04 '21 17:02 donatj