openweathermap icon indicating copy to clipboard operation
openweathermap copied to clipboard

Published 20 hours ago • verified publisher icon briandowns

API Key validation should do more than check length

Open szaydel opened this issue 5 years ago • 1 comments

Hopefully you will find this useful. I noticed that API key validation could be improved and thought I could contribute a little something. Let me know if this is useful and if want me to make any changes before you'll consider it acceptable.

Thanks, S.

szaydel avatar Feb 01 '19 05:02 szaydel

It looks like one of the tests is failing but not seemingly related to my change. Let me know if you would like me investigate this further.

szaydel avatar Feb 01 '19 05:02 szaydel

Hi, I submitted a PR at [#108] which aims to fix this issue in a similar way.

MikMuellerDev avatar Aug 16 '22 11:08 MikMuellerDev