jsonrpc4j icon indicating copy to clipboard operation
jsonrpc4j copied to clipboard

Remove usage of org.springframework.remoting.support.RemoteExporter #303

Open cyb3r4nt opened this issue 2 years ago • 3 comments

Remove usage of org.springframework.remoting.support.RemoteExporter #303

RemoteExporter was used mostly as data holder for service and serviceInterface properties. Remoting support was removed from Spring Framework 6 and Spring does not provide this class anymore.

This change moves required service and serviceInterface fields from RemoteExporter into AbstractJsonServiceExporter and removes usage of RemoteExporter. (See also comment https://github.com/briandilley/jsonrpc4j/issues/303#issuecomment-1449771543) Other bean registration logic was not changed.

This new version may fail for the users who inherited from the AbstractJsonServiceExporter class or its descendants, and directly use any functionality inherited from RemoteExporter.

I tested this with Spring Framework 6 and there were no class loading related problems in my env.

cyb3r4nt avatar Jun 13 '23 10:06 cyb3r4nt

Any deadline on merging this?

AndreMCCarvalho avatar Aug 10 '23 07:08 AndreMCCarvalho

I think Spring Boot 2.x apps will need to bump by November to avoid OSS EOL... https://endoflife.date/spring-boot Which i think maps to a shift to Spring 6.x and hence no remoting

tyro-jason avatar Sep 12 '23 01:09 tyro-jason

Hi @briandilley, could you help review this PR and release a new version for this? My current project needs to upgrade to Spring 6.x and now I'm stuck with this issue. java.lang.NoClassDefFoundError: org/springframework/remoting/support/RemoteExporter.

Thanks a lot <3

peothach avatar Oct 31 '23 09:10 peothach