jsonrpc4j icon indicating copy to clipboard operation
jsonrpc4j copied to clipboard

setExceptionLogLevel removed, and default log-level set to warn

Open bushwakko opened this issue 6 years ago • 2 comments

The code:

        if (LOGGER.isLoggable(exceptionLogLevel)) {
            LOGGER.log(exceptionLogLevel, "Error in JSON-RPC Service", thrown);
        }

that is configured via the setExceptionLogLevel method is suddenly removed and replace with:

    logger.warn("Error in JSON-RPC Service", unwrappedException);

in the commit 2658b404ac1f9424436dca8500a40ec06030959a with the less than accurate commit message:

Move to Gradle build system, refactor for cleaner code.

I wouldn't say removing functionality is either gradle-related, nor part of refactoring...

bushwakko avatar Mar 23 '18 14:03 bushwakko

After some more digging, I found another commit that seems to add functionality to not log that line at all.with "setShouldLogInvocationErrors".

bushwakko avatar Mar 23 '18 14:03 bushwakko

solved via https://github.com/briandilley/jsonrpc4j/pull/142.

wuwen5 avatar May 10 '18 08:05 wuwen5