Brian de Alwis

Results 167 comments of Brian de Alwis

`GoogleFeedback` seems clean; class analysis shows it just depends on `protobuf` and otherwise uses stock `java.net`. With @akerekes finishing off the async download, I'm taking this on. Will have something...

I'm just hooking up AERI and won't actually submit anything. I'm assuming something needs to be done to register the product and package code.

I've put up an AERI prototype on the [`aeri`](https://github.com/GoogleCloudPlatform/google-cloud-eclipse/tree/aeri) branch. Although currently disabled, it has some code to call out to the `AnonymousFeedback` class in `GoogleFeedback.jar`; it actually does work,...

@amitm02 Kubernetes [doesn't remove PVCs when deleting StatefulSets](https://kubernetes.io/docs/concepts/workloads/controllers/statefulset/#stable-storage): > Note that, the PersistentVolumes associated with the Pods' PersistentVolume Claims are not deleted when the Pods, or StatefulSet are deleted. This...

GCP's Config Connector uses a [`deletion-policy: abandon`](https://cloud.google.com/config-connector/docs/how-to/managing-deleting-resources#keeping_resources_after_deletion) to indicate that resources should not be deleted. It might be worth turning `skaffold.dev/cleanup` from a boolean to an enum to provide flexibility...

I would argue that you should not be using Skaffold to deploy a PVC (or a PV): you should be managing those outside of Skaffold — or at least outside...

What is this GPE splash screen?

> Now I see one culprit: ProjectUtils.importProjects() should call waitForProjects(projects) instead of waitForProjects(). :blush: I thought I had logic in there to treat no-projects as the entire workspace ⚡️

This should have been fixed by #2086 and #2092.

Just saw this failure on Oxygen: ``` Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 49.586 sec