deprecation icon indicating copy to clipboard operation
deprecation copied to clipboard

Published 20 hours ago • verified publisher icon briancurtin

Deprecating classes with subclasses

Open tommy-waltmann opened this issue 5 years ago • 2 comments

Deprecation decorator doesn't work on classes if the class being deprecated has a subclass that inherits from it, even if all the subclasses are marked deprecated as well.

tommy-waltmann avatar Sep 03 '19 19:09 tommy-waltmann

Hey, thanks for the report! That's not something I've come across in the past and don't have a fix off the top of my head. If you happen to beat me to it I'd be happy to review a PR.

briancurtin avatar Sep 03 '19 21:09 briancurtin

I worked a bit with @tommy-waltmann on this problem. From my understanding, decorators and classes don't play nicely together when it comes to inheritance. This StackOverflow post seems related: https://stackoverflow.com/questions/2542747/class-decorators-inheritance-super-and-maximum-recursion

bdice avatar Sep 03 '19 21:09 bdice