deprecation icon indicating copy to clipboard operation
deprecation copied to clipboard

Implement DeprecatedVariable for deprecating module level variables

Open radeklat opened this issue 5 years ago • 3 comments

  • Add class DeprecatedVariable
  • Abstract warning check into _get_warning_class()
  • Abstract warning raising into _warn_user()
  • Abstract docstring wrapping into _wrap_doctring()
  • Implement tests for DeprecatedVariable
  • Update README to mention DeprecatedVariable

radeklat avatar Jul 11 '18 22:07 radeklat

Codecov Report

Merging #35 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #35   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          83    110   +27     
  Branches       16     20    +4     
=====================================
+ Hits           83    110   +27
Impacted Files Coverage Δ
deprecation.py 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c9f228e...f786b50. Read the comment docs.

codecov-io avatar Jul 11 '18 23:07 codecov-io

Cool! Thanks for writing this up! I have a few things to think about and will try to get you a review for this in the next few days.

briancurtin avatar Jul 12 '18 20:07 briancurtin

Don't think this is the right approach personally, but Twisted, which is the best implementor of this functionality that I'm aware of, is as usual a decent place to use as a cheat sheet for this functionality IMHO.

Julian avatar Dec 29 '18 10:12 Julian