proto-loader icon indicating copy to clipboard operation
proto-loader copied to clipboard

Bug fix allowing diamond dependencies.

Open saarraz opened this issue 8 years ago • 1 comments

The current version would fail if a "diamond" dependency existed, for example: a.proto: message A { } b.proto: import "a.proto"; message B { } c.proto: import "a.proto"; import "b.proto"; --> ERROR: Duplicate message A defined.

The previous code does have a mechanism to avoid this (the 'loaded' object) but it is not passed down to recursive calls into readProto, which is a bug. Passing it down fixes the problem.

saarraz avatar Mar 25 '16 10:03 saarraz

+1

sdvcrx avatar Jun 10 '16 15:06 sdvcrx