liferay-portal
liferay-portal copied to clipboard
LPD-17027 Unsafe suppliers on optional fields (Objects)
Forwarded from: https://github.com/liferay-headless/liferay-portal/pull/1960 (Took 1 ci:forward
attempt in 2 minutes)
Console
@albertojml @liferay-headless
Original pull request comment: Purpose of this PR The main objective of this PR is improve the Objects APIs performance by using a new "lazyProperties" mechanism. This String-UnsafeSupplier map is accessed while recovering the data fields required without retrieving the optional fields which results in less queries and better performance for the APIs for the different Object entries.
What's changed?:
- Now, through Rest-Builder, every Json Map property gets an analog lazy map which will be accessed while retrieving the properties. This includes its respective getters and setters.
- The ObjectsDTOConverter has been adapted to build the Object Entries DTOs so that this lazy mechanism gets implemented.
- A new serializer for Unsafe Suppliers has been created.
- The objects nested fields infrastructure has been changed to take into account the new lazy mechanism.
- Batch Engine is adapted for this new mechanism.
What's new?:
- A new serializer for Unsafe Suppliers has been created.
- New tests for checking that the unsafe suppliers are not invoked when they're not needed.
:heavy_check_mark: ci:test:sf - 1 out of 1 jobs passed in 4 minutes
Click here for more details.
Base Branch:
Branch Name: master
Branch GIT ID: d56089f945aa90d7960108eba7f17186ac74963c
Sender Branch:
Branch Name: LPD-17027
Branch GIT ID: 1217a84edbffe5080644c78feb0d1b2cc13148ba
1 Successful Jobs:
For more details click here.
:heavy_check_mark: ci:test:stable - 33 out of 33 jobs passed
:heavy_check_mark: ci:test:relevant - 44 out of 47 jobs passed in 1 hour 50 minutes
Click here for more details.
Base Branch:
Branch Name: master
Branch GIT ID: d56089f945aa90d7960108eba7f17186ac74963c
Upstream Comparison:
Branch GIT ID: d56089f945aa90d7960108eba7f17186ac74963c
Jenkins Build URL: EE Development Acceptance (master) - 501 - 2024-04-22[12:38:53]
ci:test:stable - 33 out of 33 jobs PASSED
33 Successful Jobs:
ci:test:relevant - 43 out of 47 jobs PASSED
4 Failed Jobs:
test-portal-acceptance-pullrequest(master)- build-iw-jdk8
- central-requirements-jdk8
- empty-osgi-core-dir-mysql57-jdk8
- functional-smoke-tomcat90-mysql57-jdk8_stable
- functional-upgrade-tomcat90-mysql57-jdk8_stable
- functional-upgrade-tomcat90-mysql57-jdk8_stable/0/0
- functional-upgrade-tomcat90-mysql57-jdk8_stable/0/1
- functional-upgrade-tomcat90-mysql57-jdk8_stable/0/2
- functional-upgrade-tomcat90-mysql57-jdk8_stable/0/3
- functional-upgrade-tomcat90-mysql57-jdk8_stable/0/4
- functional-upgrade-tomcat90-mysql57-jdk8_stable/0/5
- js-unit-jdk8
- modules-compile-jdk8
- modules-compile-jdk8/0/0
- modules-compile-jdk8/0/1
- modules-compile-jdk8/0/2
- modules-compile-jdk8/0/3
- modules-compile-jdk8/0/4
- modules-compile-jdk8/0/5
- modules-compile-jdk8/0/6
- modules-compile-jdk8/0/7
- modules-compile-jdk8/0/8
- modules-compile-jdk8/0/9
- modules-compile-jdk8/0/10
- modules-compile-jdk8/0/11
- modules-compile-jdk8/0/12
- modules-integration-mysql57-jdk8
- modules-integration-mysql57-jdk8_stable
- modules-semantic-versioning-jdk8
- modules-unit-jdk8
- modules-unit-jdk8_stable
- patching-tool-mysql57-jdk8
- playwright-compile-jdk8
- playwright-js-tomcat90-mysql57-jdk8
- playwright-js-tomcat90-mysql57-jdk8_stable
- pmd-jdk8
- rest-builder-jdk8
- service-builder-jdk8
- unit-jdk8
- unit-jdk8_stable
- workspaces-compile-jdk8
43 Successful Jobs:
For more details click here.
This pull contains no unique failures.
Failures in common with acceptance upstream results at d56089f945aa90d7960108eba7f17186ac74963c:
Test bundle downloads:
- liferay-portal-bundle-tomcat.tar.gz (mirrors: dlc, lax)
To conserve resources, the PR Tester does not automatically run for forwarded pull requests.
@ccorreagg rebase error, please resend.