liferay-portal icon indicating copy to clipboard operation
liferay-portal copied to clipboard

Published 20 hours ago • verified publisher icon brianchandotcom

LPD-22886

Open liferay-continuous-integration opened this issue 10 months ago • 7 comments

Forwarded from: https://github.com/liferay-commerce/liferay-portal/pull/4892 (Took 1 ci:forward attempt in 45 seconds) Console

@brianikim @liferay-commerce

Original pull request comment: https://github.com/liferay-commerce/liferay-portal/pull/4853/ https://github.com/brianikim/liferay-portal/pull/162

@andrea-ale-sbarra , resent from above

liferay-continuous-integration avatar Apr 23 '24 08:04 liferay-continuous-integration

:heavy_check_mark: ci:test:sf - 1 out of 1 jobs passed in 5 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 0499cf89ff56a4ecbf43abc7a8a726ed015459c5

Sender Branch:

Branch Name: LPD-22886
Branch GIT ID: a02cb519881cc1ecc3267d80ec77c631753d35d3

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

liferay-continuous-integration avatar Apr 23 '24 08:04 liferay-continuous-integration

:heavy_check_mark: ci:test:stable - 33 out of 33 jobs passed

:heavy_check_mark: ci:test:relevant - 57 out of 58 jobs passed in 1 hour 41 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 0499cf89ff56a4ecbf43abc7a8a726ed015459c5

Upstream Comparison:

Branch GIT ID: 9bb99cce5d5e9bdd8c1d9facaa8ee230ba1a0d83
Jenkins Build URL: EE Development Acceptance (master) - 496 - 2024-04-17[12:38:19]

ci:test:stable - 33 out of 33 jobs PASSED
33 Successful Jobs:
    ci:test:relevant - 56 out of 58 jobs PASSED

    2 Failed Jobs:

    56 Successful Jobs:
      For more details click here.

      This pull contains no unique failures.

      Failures in common with acceptance upstream results at 9bb99cce5d5e9bdd8c1d9facaa8ee230ba1a0d83:

      liferay-continuous-integration avatar Apr 23 '24 08:04 liferay-continuous-integration

      To conserve resources, the PR Tester does not automatically run for forwarded pull requests.

      liferay-continuous-integration avatar Apr 23 '24 08:04 liferay-continuous-integration

      @brianikim the CMD values don't seem to match the JSP file names they map to. Can you resend? Thx.

      brianchandotcom avatar Apr 24 '24 18:04 brianchandotcom

      ci:reopen

      brianikim avatar Apr 24 '24 18:04 brianikim

      @brianchandotcom , this was done intentionally.

      I would say our naming scheme is fairly unique in circumstance.

      ~~I do not see many CMD values being matched to the JSP file names they map to.~~ I do see examples of this.

      For the naming scheme here, it was explicitly done to "match" to the actionURL used. For example:

      		<aui:form action="<%= editProductDefinitionProductGroupsActionURL %>" method="post" name="fm">
			<aui:input name="<%= Constants.CMD %>" type="hidden" value="updateProductGroups" />

      <portlet:actionURL name="/cp_definitions/edit_cp_definition" var="editProductDefinitionAttachmentsActionURL" />

	<aui:form action="<%= editProductDefinitionAttachmentsActionURL %>" cssClass="pt-4" method="post" name="fm">
		<aui:input name="<%= Constants.CMD %>" type="hidden" value="updateAttachments" />

      I intentionally stripped out editProductDefinition and repurposed the value to "update" + "x"

      brianikim avatar Apr 24 '24 18:04 brianikim

      Using above example,

      Would following be more acceptable @brianchandotcom ?

      updateAttachments -> updateAttachmentFileEntries updateProductGroups -> updatePricingClasses

      brianikim avatar Apr 24 '24 18:04 brianikim

      https://github.com/brianchandotcom/liferay-portal/pull/149700

      brianikim avatar Apr 26 '24 02:04 brianikim