liferay-portal icon indicating copy to clipboard operation
liferay-portal copied to clipboard

LPD-21645 Instance settings default permissions

Open smottal opened this issue 10 months ago • 1 comments

https://liferay.atlassian.net/browse/LPD-21645

Resent from: https://github.com/brianchandotcom/liferay-portal/pull/149392 changing "asset naming"

Sent directly from https://github.com/liferay-commerce/liferay-portal/pull/4897 because the SF / stable doesn't pass for not related things and from a previous stable success I did a rebase to solve only a conflict in a playwright configuration file.

smottal avatar Apr 22 '24 16:04 smottal

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@smottal this is in the wrong package:

package com.liferay.portal.defaultpermissions.web.internal.configuration;

import com.liferay.portal.configuration.metatype.annotations.ExtendedObjectClassDefinition;
import com.liferay.portal.defaultpermissions.resource.PortalDefaultPermissionsModelResource;

import org.osgi.service.component.annotations.Component;

/**
 * @author Stefano Motta
 */
@Component(
	property = "portal.default.permissions.model.resource.key=" + LayoutModelResourcePortalDefaultPermissions.MODEL_RESOURCE_KEY,
	service = PortalDefaultPermissionsModelResource.class
)
public class LayoutModelResourcePortalDefaultPermissions
	implements PortalDefaultPermissionsModelResource {

Naming is off too and doesn't match our

XyzBlah implements Blah pattern

Please resend. May have other classes with the same package / naming issue.

brianchandotcom avatar Apr 29 '24 16:04 brianchandotcom