liferay-portal icon indicating copy to clipboard operation
liferay-portal copied to clipboard

Published 20 hours ago • verified publisher icon brianchandotcom

LPS 197132 Unchecked extension format between file and filename

Open liferay-continuous-integration opened this issue 10 months ago • 3 comments

Forwarded from: https://github.com/liferay-content-management/liferay-portal/pull/5357 (Took 2 ci:forward attempts in 3 days 6 hours 4 minutes) Console

@manuelRives @liferay-content-management

Original pull request comment: Changes requested on https://github.com/brianchandotcom/liferay-portal/pull/144178

liferay-continuous-integration avatar Apr 22 '24 14:04 liferay-continuous-integration

To conserve resources, the PR Tester does not automatically run for forwarded pull requests.

liferay-continuous-integration avatar Apr 22 '24 14:04 liferay-continuous-integration

:heavy_check_mark: ci:test:sf - 1 out of 1 jobs passed in 6 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 9bb99cce5d5e9bdd8c1d9facaa8ee230ba1a0d83

Sender Branch:

Branch Name: LPS-197132-changedException
Branch GIT ID: d21fecd976285572e2335f073276ff8983c953be

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

liferay-continuous-integration avatar Apr 22 '24 14:04 liferay-continuous-integration

Previous ci:test:relevantbuild was unsuccessfully reevaluated against more recent upstream results.

:heavy_check_mark: ci:test:stable - 32 out of 32 jobs passed

:x: ci:test:relevant - 144 out of 169 jobs passed in 2 hours 10 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: db0de24df2ce723e07dfe03e4d4f8af0c228231e

Upstream Comparison:

Branch GIT ID: db0de24df2ce723e07dfe03e4d4f8af0c228231e
Jenkins Build URL: EE Development Acceptance (master) - 498 - 2024-04-19[04:38:13]

ci:test:stable - 32 out of 32 jobs PASSED
32 Successful Jobs:
    ci:test:relevant - 144 out of 169 jobs PASSED

    25 Failed Jobs:

    144 Successful Jobs:
      For more details click here.

      Failures unique to this pull:

      4. unit-jdk8/0/0
        1. com.liferay.taglib.theme.MetaTagsTagTest.testMetaTagsTagInternalServerErrorResponseStatus - UNTESTED
        2. com.liferay.taglib.theme.MetaTagsTagTest.testMetaTagsTagLayoutRobots - UNTESTED
        3. com.liferay.taglib.theme.MetaTagsTagTest.testMetaTagsTagLocalizedLayoutRobots - UNTESTED
        4. ...
      Failures in common with acceptance upstream results at db0de24df2ce723e07dfe03e4d4f8af0c228231e:
      2. ...

      liferay-continuous-integration avatar Apr 22 '24 14:04 liferay-continuous-integration

      @manuelRives

      public class FileExtensionException extends PortalException {

	public FileExtensionException() {
	}

	public FileExtensionException(String msg) {
		super(msg);
	}

	public FileExtensionException(String msg, Throwable throwable) {
		super(msg, throwable);
	}

	public FileExtensionException(Throwable throwable) {
		super(throwable);
	}

	public static class MismatchExtension extends FileExtensionException {

		public MismatchExtension(String msg) {
			super(msg);
		}

	}

}

      An exception class is either a constructor based class or "static class". Never both. Please fix and resend.

      See:

      git grep "static class" **Exception.java

      brianchandotcom avatar Apr 29 '24 14:04 brianchandotcom