node-postgres icon indicating copy to clipboard operation
node-postgres copied to clipboard

Release notes 8.13.0

Open kirrg001 opened this issue 1 year ago • 1 comments

Hi there!

Could you please publish release notes for 8.13.0?

The diff looks pretty big: https://github.com/brianc/node-postgres/compare/pg%408.12.0...pg%408.13.0

Thanks a lot

kirrg001 avatar Sep 19 '24 07:09 kirrg001

Can we please have release notes? We can't upgrade without knowing what's changed.

markedwards avatar Oct 04 '24 11:10 markedwards

Bump on this!

Yareaj avatar Oct 21 '24 16:10 Yareaj

@brianc

DavideViolante avatar Oct 30 '24 13:10 DavideViolante

https://github.com/brianc/node-postgres/blob/master/CHANGELOG.md#pg8130

brianc avatar Oct 31 '24 00:10 brianc

Sorry but the PR linked in the changelog changes just 2 lines of code and add 1 test, while the comparison between v8.12 and v8.13 are 807 additions and 1,558 deletions. A better detail on the changelog would be appreciated. Also v8.13.1 is missing.

DavideViolante avatar Oct 31 '24 08:10 DavideViolante

I recommend you to use semantic-release or similar in the future so you can automate and improve the process of the releases and changelog. There are at least 4 different (but closed) issues about changelog, so it's a problem that developers are now feeling. Since pg is a core library in any project, we can't upgrade without knowing the changes and the reason of the changes, as @markedwards said.

DavideViolante avatar Nov 04 '24 09:11 DavideViolante

cc @MyNameIsNeXTSTEP Could you please help?

kirrg001 avatar Dec 09 '24 10:12 kirrg001

@kirrg001 I'd like to Give me a little guiadence what to do exactly please

MyNameIsNeXTSTEP avatar Dec 09 '24 11:12 MyNameIsNeXTSTEP

The git diff https://github.com/brianc/node-postgres/compare/[email protected]@8.13.0 looks very big. It contains 28 commits, 807 additions and 1,558 deletions.

The community was wondering why the public changelog only contains one change:

Add ability to specify query timeout on https://github.com/brianc/node-postgres/pull/3074.

Could you please double check and confirm that this is the only customer facing change?

Thanks a lot!

kirrg001 avatar Dec 09 '24 11:12 kirrg001

@kirrg001 If i understood you correctly, here what i've done so far.

As I explored the comparing changes I have found these customer facing changes (which customers may face using the lib) not inluded in the current changelog description for v8.13.0:

  • PR 3114
    • Docs example of pg-cloudflare usage in a non-nodejs environment
  • PR 3170
    • Check Cloudflare API environment first, fallback to NodeJS in case of failure
  • PR 3251 (maybe for contributiors)
    • Devcontainer now uses postgres:14-alpine

MyNameIsNeXTSTEP avatar Dec 09 '24 12:12 MyNameIsNeXTSTEP

Could you please update your CHANGELOG?

Furthermore, it would be really helpful for the community if you could start using GH releases as well.

Thank you!

kirrg001 avatar Dec 10 '24 09:12 kirrg001

@brianc FYI

MyNameIsNeXTSTEP avatar Dec 10 '24 12:12 MyNameIsNeXTSTEP

Fwiw, I am happy with current release practices and grateful for all the hard work and contributions over the years. Thank you!

Straight forward enough to use git to see what files changed between releases.

wulfsolter avatar Dec 10 '24 23:12 wulfsolter

I am also confused why there is no changelog entry for 8.13.1.

kirrg001 avatar Dec 11 '24 09:12 kirrg001

Just use the github releases please @brianc , it's extremely simple:

  • people make changes, merge some PRs
  • go to releases, click New release, click "Generate release notes"
  • click publish and all the changes will be very clear for everyone

In this way you save time on creating tags, updating changelog, etc

DavideViolante avatar Dec 11 '24 09:12 DavideViolante