node-postgres icon indicating copy to clipboard operation
node-postgres copied to clipboard

Kerberos support for node-postgres

Open blackentropy opened this issue 1 year ago • 7 comments

blackentropy avatar Jun 25 '24 21:06 blackentropy

@brianc We'd ideally like to get this merged and released through the main package. Could you let us know what the procedure would be? There's unfortunately not a lot of documentation for this flow, and it's not well trodden.

albertchang avatar Jul 03 '24 20:07 albertchang

We'd ideally like to get this merged and released through the main package. Could you let us know what the procedure would be?

I can do that! Its very easy on my side to release new versions. Ideally all features should have tests along side them. I realize testing against a kerberos system is.... unpleasant ... do you have any way you could include tests? Even the pg-protocol stuff typically ships with unit tests. Its very high likelyhood without tests sometime within the next 10 years this code will change and/or break without them.

brianc avatar Jul 03 '24 21:07 brianc

@albertchang note also: CI is running on this PR now & lint is failing

brianc avatar Jul 03 '24 21:07 brianc

We'd ideally like to get this merged and released through the main package. Could you let us know what the procedure would be?

I can do that! Its very easy on my side to release new versions. Ideally all features should have tests along side them. I realize testing against a kerberos system is.... unpleasant ... do you have any way you could include tests? Even the pg-protocol stuff typically ships with unit tests. Its very high likelyhood without tests sometime within the next 10 years this code will change and/or break without them.

Cool, I'll try to take a stab at writing some tests for this change and circle back afterwards. Thanks!

Also, is CI not configured to run automatically on changes to the branch?

albertchang avatar Jul 03 '24 22:07 albertchang

Also, is CI not configured to run automatically on changes to the branch?

Boo i need to set that up. having to keep re-approving it is no bueno!

brianc avatar Jul 04 '24 02:07 brianc

@brianc Could you approve the workflow run for CI? Thanks!

albertchang avatar Sep 27 '24 05:09 albertchang

@brianc Would also appreciate a review when you get a chance!

albertchang avatar Sep 30 '24 17:09 albertchang