node-postgres
node-postgres copied to clipboard
[pg-cursor] Add query_timeout parameter to test code to trigger queryCallback bug
There is a bug in the query callback handling (e.g. #1860 #2560) but the test code doesn't pick it up. This change ensures that code path runs in the tests, so it will probably make the tests fail until the bug is fixed. (I say 'probably' because the exception doesn't get thrown until after all the tests have completed successfully.)
node-postgres/packages/pg-cursor/node_modules/mocha/lib/runner.js:911
throw err;
^
TypeError: queryCallback is not a function
at Timeout._onTimeout (node-postgres/packages/pg-cursor/node_modules/pg/lib/client.js:532:9)
at listOnTimeout (node:internal/timers:557:17)
at processTimers (node:internal/timers:500:7)
The weird thing is github actions isn't running on this PR. :( I might not have added the right thing to it to run on a pull or something...I'll have to look into that.
Thanks for this btw! And sorry for the delay: was out of town until last night.
@brianc you must add on: [push, pull_request]
to the ci.yml
config file to run on a PR ^^
@brianc you must add
on: [push, pull_request]
to theci.yml
config file to run on a PR ^^
roger, wilco!
@brianc is there any solution to this bug?
@brianc, Please provide ETA for this fix - to prevent Fatal exception using "query_timeout" with queryStream.