node-pg-query-stream icon indicating copy to clipboard operation
node-pg-query-stream copied to clipboard

Published 20 hours ago • verified publisher icon brianc

Do not emit 'close' event after you finished read rows

Open btd opened this issue 5 years ago • 5 comments

This fixes https://github.com/brianc/node-pg-query-stream/issues/52

btd avatar Mar 04 '19 10:03 btd

The failing tests is exactly where is bug happen. Wrong 'close' event semantic.

btd avatar Mar 04 '19 11:03 btd

bump

eljefedelrodeodeljefe avatar May 01 '19 14:05 eljefedelrodeodeljefe

@mcollina done. But have a question: according to docs, close event is not required to be emitted. So now it is a bit unclear how this stream should handle it.

btd avatar May 10 '19 11:05 btd

https://github.com/brianc/node-pg-query-stream/issues/52#issuecomment-561644112

matthieusieben avatar Dec 04 '19 13:12 matthieusieben

note to myself: need to integrate #52 changes + more tests into the monorepo once the port is done (sometime next week)

brianc avatar Dec 20 '19 17:12 brianc