node-pg-pool icon indicating copy to clipboard operation
node-pg-pool copied to clipboard

fix for cases where connection is broken and release() is called, avo…

Open olgkpln opened this issue 6 years ago • 4 comments

Fixing a case when release() is called for a broken connection. without this, the broken connection is returned to the idle pool and reused.

olgkpln avatar Feb 06 '19 10:02 olgkpln

Thanks for the pull request @olgkpln! Any way you could write a test for this?

brianc avatar Feb 11 '19 16:02 brianc

I think https://github.com/brianc/node-pg-pool/pull/115 is a better way to prevent this or is there any other way then double releasing the client to trigger this bug?

johanneswuerbach avatar Feb 11 '19 18:02 johanneswuerbach

ah yeah if #115 fixes this I can just merge that one.

brianc avatar Feb 11 '19 19:02 brianc

#115 is a good fix as well

olgkpln avatar Feb 12 '19 15:02 olgkpln