brianc
Is this unsupported?
I still use it - it's just pretty simple & doesn't really need much more so it doesn't really get updated unless I hit a bug with it.
On Tue, Jun 7, 2016 at 5:06 AM, Jade Mulholland [email protected] wrote:
Seems like it's been a while since the last update. Is it now unsupported?
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/brianc/node-domain-middleware/issues/14, or mute the thread https://github.com/notifications/unsubscribe/AADDoaKHafqiqUymo1kvQLDJfEsPREZuks5qJUKugaJpZM4Ivwqt .
AFAIK, yes
On Tue, Jun 7, 2016 at 7:06 PM, Jade Mulholland [email protected] wrote:
Awesome. So it's still compatible with the latest version of NodeJS?
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/brianc/node-domain-middleware/issues/14#issuecomment-224450865, or mute the thread https://github.com/notifications/unsubscribe/AADDoQF36li2sPuqvADT5CnQUGdlyacdks5qJgefgaJpZM4Ivwqt .
It might still work but please note that Domains have been officially deprecated -
Most end users should not have cause to use this module. Users who absolutely must have the functionality that domains provide may rely on it for the time being but should expect to have to migrate to a different solution in the future
https://nodejs.org/api/domain.html
Yeah. Do you know of a viable alternative to domains? I was under the impression that was still the best one could get at managing async errors & keeping context in a long block of CSP code.
On Wed, Jun 8, 2016 at 12:33 PM, avnersorek [email protected] wrote:
It might still work but please note that Domains have been officially deprecated -
Most end users should not have cause to use this module. Users who absolutely must have the functionality that domains provide may rely on it for the time being but should expect to have to migrate to a different solution in the future
https://nodejs.org/api/domain.html
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/brianc/node-domain-middleware/issues/14#issuecomment-224667996, or mute the thread https://github.com/notifications/unsubscribe/AADDoUBDfLGJe9lJgmYDO3Dtawlj-BSSks5qJvzVgaJpZM4Ivwqt .
nope :cry: I'll probably keep using domains until they remove them altogether and hopefully by then there will be some sort of alternative.
Domain were softly deprecated more than one year ago. The core node.js developers hate them because of the amount of code necessary around APIs to keep domains working. Some use cases are broken in the latest version of node. But nobody came out with a better alternative.
Is it possible to improve this module (perhaps version 1.0) in the way documentation says:
The better approach is to send an error response to the request that triggered the error, while letting the others finish in their normal time, and stop listening for new requests in that worker.
It says a domains usually causes a resources leak, the proper way would be to stop accepting new connections, wait until current connections are finished, possibly with configurable timeout, and then process.exit(1); to allow a supervisor mechanishm to restart an app.
