react-native-masonry icon indicating copy to clipboard operation
react-native-masonry copied to clipboard

name is misleading this is for images only

Open ConnectedReasoning opened this issue 6 years ago • 2 comments
trafficstars

Expected Behavior

It should allow for general content

Current Behavior

renders only images

Possible Solution

allow other html components to be displayed as bricks, change name to reflect the narrow image only scope of component.

Steps to Reproduce

replace images in bricks with other kinds of react components, like Text

Context (Environment)

Detailed Description

Possible Implementation

ConnectedReasoning avatar Apr 04 '19 20:04 ConnectedReasoning

Excellent point. This really spawned from the limitations of managing images when trying to use flexbox to create a typical masonry layout due to the fact that you need dimensions prior to perform resizing.

With other elements such as text and views, a masonry layout is pretty easy to accomplish with just the use of flexbox and standard column layouts i.e.: [row flex: [column 1][column2] ])

It's possible to expand the scope to other elements, however, some sort ordering will behave oddly due to the async nature, i.e: text will render first in the list no matter what. We just need to discuss the expectations of these behaviors and we should be able to implement it.

brh55 avatar Apr 04 '19 21:04 brh55

@brh55 How is masonry layout with more than one column easy to accomplish with just using flexbox?

bartzy avatar Nov 23 '19 20:11 bartzy