Brendan Reville

Results 14 comments of Brendan Reville

> Looking at something like https://github.com/code-dot-org/code-dot-org/blob/cf26e3b8d5dbf70437a35f2983c51acca8de785d/apps/src/templates/Notification.jsx#L96C7-L96C17, is GA event with the category "teacher_announcement", action name "click" maintained here? No, I removed them because I wasn't sure if anybody was still...

> Is the idea that we will still need to create individual library files for each distinct use case, but those libraries can be made up of partials that can...

> Seems fine as is, but wondering if it might make sense to store attribution information like this in the library JSON since the rest of the credits are derived...

> LGTM! Is it worth a brief code comment explaining the magic number 2? @hannahbergam I'm glad you asked, because I didn't have a great answer beyond it working for...