Brett Zamir

Results 881 comments of Brett Zamir

> I think this is a very good approach to autogenerating the types. We could adopt some of these techniques in other repositories to simplify complexity. Great... If you end...

> Since `espree` types are a new feature, what do you think about adding tests for it? Sure. > We already have type tests for `eslint-visitor-keys` in [`packages/eslint-visitor-keys/test-d/index.test-d.ts`](https://github.com/eslint/js/blob/main/packages/eslint-visitor-keys/test-d/index.test-d.ts) and we...

> Hi, I have a question about this PR! > > Could this PR fully replace `@types/espree`? Yes, that is the plan, and the approach was confirmed in https://github.com/eslint/js/issues/529#issuecomment-1013389654 ....

Have you all set `browserslist` in `package.json` as per https://github.com/keithamus/eslint-plugin-escompat?tab=readme-ov-file#targeting-browsers ?

@Kein : Did you misname the config file? It should be `.browserslistrc` with an "s". @lovelyelfpop : Greater than 1% resolves to these browsers per browserslist: ```js [ 'and_chr 137',...

@gajus : Do you want to take a look?

As per #36, some features are missing. Try using `eslint-plugin-compat` (instead of this escompat plugin) with `settings: {lintAllEsApis: true}`. That appears to catch the `BigInt` constructor as well.

Is it because pnpm is not allowable as per https://github.com/semantic-release/npm/issues/280 ? Might https://www.npmjs.com/package/semantic-release-pnpm assist?

I think this issue can now be closed per https://github.com/commonbaseapp/zodex/issues/49#issuecomment-3160173363 .

I don't think there is a need for `overrides` if one runs `npm upgrade`. The 3.0.0 release has `"zod": "^3.24.1"` for `dependencies` (and `"zod": "^3.x"` for `peerDependencies`), so it should...