HikariCP icon indicating copy to clipboard operation
HikariCP copied to clipboard

Published 20 hours ago • verified publisher icon brettwooldridge

Added Support For beginRequest and endRequest (new version)

Open fmeheust opened this issue 1 year ago • 4 comments

Continued work from pull request https://github.com/brettwooldridge/HikariCP/pull/2079. Addressed review comments https://github.com/brettwooldridge/HikariCP/pull/2079#discussion_r1367934838 and added tests.

fmeheust avatar Oct 24 '23 10:10 fmeheust

Given that this is a Java 11+ version of HikariCP and that request boundaries (Connection.beginRequest() and Connection.endRequest()) are present since Java 9, I have removed the check for JDBC version. I have added a property that allows to explicitly enable request boundaries. Calls to Connection.beginRequest() and Connection.endRequest() have been moved to HikariPool.getConnection and HikariPool.recycle respectively.

fmeheust avatar Oct 30 '23 20:10 fmeheust

@lfbayer Can you please review my latest changes to this pull request ?

fmeheust avatar Nov 06 '23 18:11 fmeheust

@lfbayer could you please review this request? Thank you!

jeandelavarene avatar Feb 02 '24 09:02 jeandelavarene

Hi @lfbayer any update on the merge? Thanks!

krismohan avatar Apr 19 '24 07:04 krismohan