HikariCP icon indicating copy to clipboard operation
HikariCP copied to clipboard

OSGi package exports missing for metrics integrations

Open driessamyn opened this issue 2 years ago • 4 comments

Currently, HikariCP OSGi Exports a limited number of packages. In particularly, the dropwizard, micrometer and prometheus integrations are missing from the exports, preventing those to be used in an OSGi environment. I only need the micrometer one, but I have created the below PR that adds all 3.

https://github.com/brettwooldridge/HikariCP/pull/1989

The build seems to fail due to reduction in test coverage, however, the PR doesn't actually change code, only impacts the generated MANIFEST.MF

driessamyn avatar Oct 13 '22 12:10 driessamyn

Thanks for merging this PR a while ago, @lfbayer .

Is there any indication if a next release may happen that will include this fix?

driessamyn avatar Feb 24 '23 09:02 driessamyn

@driessamyn, I wanted to handle the password contributor ( PR #2011 ) ticket that many people were clambering for before doing a release, but life and the day job seem to get in the way. A while back @brettwooldridge warned me that we have to be very careful with the semantic versioning and I'm actually not sure how to tell if the major version needs to be increased given the changes that have been made. I was thinking that if I added a big change like the password contributor then I wouldn't need to think about and could just increment the major version regardless.

If I had confidence on the semantic version question then doing a release wouldn't take me more than half an hour or so.

lfbayer avatar Feb 24 '23 15:02 lfbayer

@driessamyn, I wanted to handle the password contributor ( PR #2011 ) ticket that many people were clambering for before doing a release, but life and the day job seem to get in the way. A while back @brettwooldridge warned me that we have to be very careful with the semantic versioning and I'm actually not sure how to tell if the major version needs to be increased given the changes that have been made. I was thinking that if I added a big change like the password contributor then I wouldn't need to think about and could just increment the major version regardless.

If I had confidence on the semantic version question then doing a release wouldn't take me more than half an hour or so.

Hi @lfbayer , any ETA yet about when a release can be expected that contains this change?

driessamyn avatar Sep 11 '23 12:09 driessamyn

I decided that it is better to not implement anything within HikariCP for the password contributor which means the question about semantic versioning remains. I suppose if I had confidence in what the correct version should be for a release I could just pull the trigger and do a release. Any help on that front would be appreciated.

lfbayer avatar Sep 12 '23 12:09 lfbayer