brettpac

I agree that this would be a valuable addition to the client library, with numerous use cases. I also like the idea of developing it in noetic. We plan on...

Hey @yassiezar. Is there any issue with moving the client folder https://github.com/yassiezar/SMACC2/tree/http-client/smacc2_sm_reference_library/sm_atomic_http/include/sm_atomic_http/clients/client_behaviors to the https://github.com/robosoft-ai/SMACC2/tree/humble/smacc2_client_library folder?

Are there any complications with... Moving the client https://github.com/yassiezar/SMACC2/blob/http-client/smacc2/include/smacc2/client_bases/smacc_http_client.hpp, to it's own folder in the smacc_client_library folder? Moving the code to a cpp file? Let's chat offline about this.

Closing this one out as answered.

Hi @AlexanderStohr, most (if not all) of the changes in these PRs have now been integrated into the humble branch so I'm going to close this out. Thank you for...

I think it's just being held up by precommit... Command: pre-commit run -a

Hi @yassiezar , thank you for this pull request. Looks awesome. One last request... For the cb_http_request found here... [smacc2_sm_reference_library/sm_atomic_http/include/sm_atomic_http/clients/client_behaviors](smacc2_sm_reference_library/sm_atomic_http/include/sm_atomic_http/clients/client_behaviors) Let's move that into a new folder entitled "client_behaviors" and...

Hi Jaycee, looks like we're missing some copyrights... smacc2_client_library/http_client/src/http_client/http_session.cpp: could not find copyright notices... ``` 1 errors, checked 306 files smacc2_client_library/http_client/src/http_client/ssl_http_session.cpp: could not find copyright notice 1 errors, checked 296...

// Copyright 2021 RobosoftAI Inc. // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. //...

Hmmm. As Im reading it, the failed binary check is tied to the sm_simple_action_client state machine package I just merged a few minutes ago...