git2consul icon indicating copy to clipboard operation
git2consul copied to clipboard

Add support for the "support_tags" command when running with no hooks…

Open lambdaknight opened this issue 8 years ago • 7 comments

… or in "no daemon" mode.

I added a issue (#139) about "support_tags" not working in "no daemon" mode. I made a small change that gets it working. Not sure it is the optimal way to do it, but I leave it here for your perusal.

lambdaknight avatar Feb 22 '17 15:02 lambdaknight

Awesome! Can you add some tests for these changes?

calvn avatar Feb 22 '17 18:02 calvn

I added a test. Sorry this took so long. I don't have much time to work on this. As a disclaimer, I want to say that I don't program in JS much, so apologies if this code is just absolutely terrible.

lambdaknight avatar Mar 02 '17 17:03 lambdaknight

Can you rebase this so that it picks up the fixes to the broken test suite?

breser avatar Aug 12 '17 04:08 breser

Could you please give some information when this fix will be merged to the master branch? Thank you @breser

khdevel avatar Aug 24 '17 09:08 khdevel

@khdevel Was hoping @lambdaknight would rebase this so that I could see that the tests properly pass since the test suite was broken when he did this. Hasn't happened yet so I need to find some time to do it myself.

breser avatar Aug 24 '17 23:08 breser

Great @breser ! I extremely need such change for my super-mega deployment process :) I am looking forward for it!

khdevel avatar Aug 25 '17 07:08 khdevel

...any news about the release day?

khdevel avatar Nov 07 '17 05:11 khdevel