clj-diff icon indicating copy to clipboard operation
clj-diff copied to clipboard

Published 20 hours ago • verified publisher icon brentonashworth

Replace nil with explicit sentinel for diff and patch

Open pithyless opened this issue 5 years ago • 2 comments

Nil is a valid value in a sequence, but was used as an iterator marker, causing program to hang. Similarly, patch used nil as a deletion-marker.

This commit replaces both nil uses with explicit sentinel values.

pithyless avatar Mar 16 '19 11:03 pithyless

I suggest making your PR to https://github.com/droitfintech/clj-diff instead. They have a non-SNAPSHOT release of a fork and are clearly the communities preferred version. (9000+ downloads vs this SNAPSHOT deployment at 2000+).

terjedahl avatar Mar 16 '19 21:03 terjedahl

FYI: This was fixed and released in community fork: [tech.droit/clj-diff "1.0.1"]

pithyless avatar Mar 18 '19 14:03 pithyless