synt icon indicating copy to clipboard operation
synt copied to clipboard

Ability to ignore files

Open obenjiro opened this issue 7 years ago • 4 comments

fixes #87

obenjiro avatar Jun 11 '17 23:06 obenjiro

@aiboy thanks for the PR and feature! :-)

This looks solid. Thanks as well for the tests and kudos for picking ignore- I was thinking the same!

Feature wise:

  • Unless I am wrong, we should probably change glob (i.e. in CLI options help) to pattern, given that node-ignore technically supports gitignore spec vs exclusively glob style?
  • Have a way to support multiple paths (perhaps: -i *.ts,foo)?

Style wise (I can always do this if it's annoying):

  • No semicolons in src
  • Ideally make use of -d by default for test fixture output
  • Don't need to commit lib (no worries if annoying to remove)

Thoughts? :-)

brentlintner avatar Jun 13 '17 17:06 brentlintner

@brentlintner You're the boss :) I will fix this today or tomorrow and return back to you for additional feedback.

PS: about committing "lib" folder. Mb we should add it to gitignore then? Should I do it or not?

obenjiro avatar Jun 13 '17 17:06 obenjiro

@aiboy ok cool. :-)

As for adding lib to .gitignore I had it there before, but once I started committing lib files upon each release then no matter what lib files would show up as unstaged. :-S If you know/find an ideal way, then awesome! No worries if not. :-)

brentlintner avatar Jun 13 '17 17:06 brentlintner

@brentlintner You'll want to remove the files from being tracked. See: https://stackoverflow.com/questions/1274057/how-to-make-git-forget-about-a-file-that-was-tracked-but-is-now-in-gitignore

cdierkens avatar Jun 16 '17 13:06 cdierkens