appmeshworkshop icon indicating copy to clipboard operation
appmeshworkshop copied to clipboard

build-containers

Open jinseo-jang opened this issue 4 years ago • 2 comments

in build-containers scripts, docker build command should be adjusted to find proper Dockerfiles. docker build -t crystal-service ../ecsdemo-crystal or docker build -t crystal-service ~/environment/ecsdemo-crystal

jinseo-jang avatar Aug 24 '20 06:08 jinseo-jang

Is this an actual issue or an improvement? If I am not mistaken, following the workshop instructions you are intended to run the generated script from the ~/environment path, hence the docker build commands work as expected. In any case, I agree that its a quick change that could avoid the script failing out should someone decides to run it from somewhere else.

jeeslo avatar Aug 31 '20 22:08 jeeslo

yes. it can be an improvement in case learners are just lost where to execute that script.

jinseo-jang avatar Sep 02 '20 09:09 jinseo-jang