polyjuice icon indicating copy to clipboard operation
polyjuice copied to clipboard

Published 20 hours ago • verified publisher icon brenolf

Is there a way to prevent rule dropping?

Open marcfielding1 opened this issue 7 years ago • 3 comments

Heya,

So we've testing this out, it's really handy but it drops some rules the Eslint would support , for example ShellJS environment.

What are the criteria for rules being dropped, is it simply that they don't have a mapping presently?

Cheers

Marc

marcfielding1 avatar Jul 05 '17 09:07 marcfielding1

Yes, exactly. So the way it works is by looking at some pre-defined dictionaries in lib/dictionaries. If it fails to find a file converting the rule you're targeting, then it drops that rule.

I tried my best to comply with all rules present in ESLint docs for v1.7.2, but maybe something changed in the between. Is this env coming from JSCS ou JSHint? Because it should be copying over if it comes from JSHint. If it's not, we have a bug.

brenolf avatar Jul 05 '17 12:07 brenolf

Hey Brenolf sorry I've just noticed this, let me pull the latest version and I'll check it to make sure I'm right, I can always whip up a PR if I've found some!

marcfielding1 avatar Sep 14 '17 14:09 marcfielding1

Nothing has really changed since you opened the issue, other than supporting allButNested in eequireSpacesInsideObjectBrackets.

You're more than welcome to open a PR with a fix for anything you find that might be enhanced 😄

brenolf avatar Sep 14 '17 17:09 brenolf