ranked-model
ranked-model copied to clipboard
Adds interface `#{column_name}_rank_after!` to the gem
Hi @brendon,
I have created this PR just to capture initial thoughts on the implementation. This is still a WIP and not the final changeset.
Let me know how it looks :)
Thanks!
Good progress :) Let me know when you're ready for me to take a look again :)
@brendon - I think the PR is ready for the final stages of review :)
Hi @pragyadaga, my apologies too for the delay on this. I want to look at this next week if that's ok. I'm glad you agree that we should probably look at adding more to the ranker interface rather than adding extra methods to the model itself. I think regarding this change, we shouldn't introduce something that we then want to back-track on. But we can use this as a case for introducing the new interface standard.
I'll be in touch next week if all goes to plan :)
Hi @brendon - Thanks for getting back on this :) Yes, I agree we should not introduce something which would be difficult to revert.
Look forward to touch-basing on this next week then :)
Hi @pragyadaga, sorry I've not got on to this. I'm in a very busy phase at the moment with paid work :) It's definitely still on the agenda. Finding time is challenging though. I'll jump in when I can :)
Hi @pragyadaga, I'm so sorry this languished for so long. Just wondering if it's something worth pursuing anymore. I've since released another gem that handles ordering: https://github.com/brendon/positioning
I've tried to grok what this PR was about but it's a bit unclear now to me :) I'll close if for now, but let me know if you still want to pursue it. I think I was uncomfortable about polluting the model namespace with extra methods. My other gem also doesn't pollute the model namespace apart from a couple of methods so there could be a better way :)