ranked-model icon indicating copy to clipboard operation
ranked-model copied to clipboard

Adds interface `#{column_name}_rank_after!` to the gem

Open pragyadaga opened this issue 6 years ago • 6 comments

pragyadaga avatar Mar 16 '19 17:03 pragyadaga

Hi @brendon,

I have created this PR just to capture initial thoughts on the implementation. This is still a WIP and not the final changeset.

Let me know how it looks :)

Thanks!

pragyadaga avatar Mar 16 '19 17:03 pragyadaga

Good progress :) Let me know when you're ready for me to take a look again :)

brendon avatar Apr 23 '19 20:04 brendon

@brendon - I think the PR is ready for the final stages of review :)

pragyadaga avatar Apr 24 '19 05:04 pragyadaga

Hi @pragyadaga, my apologies too for the delay on this. I want to look at this next week if that's ok. I'm glad you agree that we should probably look at adding more to the ranker interface rather than adding extra methods to the model itself. I think regarding this change, we shouldn't introduce something that we then want to back-track on. But we can use this as a case for introducing the new interface standard.

I'll be in touch next week if all goes to plan :)

brendon avatar Sep 12 '19 20:09 brendon

Hi @brendon - Thanks for getting back on this :) Yes, I agree we should not introduce something which would be difficult to revert.

Look forward to touch-basing on this next week then :)

pragyadaga avatar Sep 13 '19 13:09 pragyadaga

Hi @pragyadaga, sorry I've not got on to this. I'm in a very busy phase at the moment with paid work :) It's definitely still on the agenda. Finding time is challenging though. I'll jump in when I can :)

brendon avatar Oct 15 '19 20:10 brendon

Hi @pragyadaga, I'm so sorry this languished for so long. Just wondering if it's something worth pursuing anymore. I've since released another gem that handles ordering: https://github.com/brendon/positioning

I've tried to grok what this PR was about but it's a bit unclear now to me :) I'll close if for now, but let me know if you still want to pursue it. I think I was uncomfortable about polluting the model namespace with extra methods. My other gem also doesn't pollute the model namespace apart from a couple of methods so there could be a better way :)

brendon avatar Jun 04 '24 04:06 brendon