Brenden Soares

Results 128 comments of Brenden Soares

@anonx I don't think it's possible to access the controller context in a test suite since you're making HTTP calls. You can only test against the textual response. Have you...

@anonx I see what you're thinking. That seems a tad complex, but it would definitely allow for more detailed testing.

@ptman can you give me some more context? What should you be able to do? @notzippy since you developed the session engine, do you have any insight?

@robfig can you accept this PR?

I'm sure we can have both, but maybe that's something to improve for Revel 2.0

Ya, for now. I just backlogged it.

Thanks @hewei-github! This looks like a similar issue I've seen in another issue. I've labeled this so we can add it to our queue of issues. Currently, it looks like...

I appreciate the unit tests you included, but could you also provide steps to reproduce the vulnerability so we can verify this correctly addresses it? Thank you for contributing to...

Added new code review comments. Also, I got your proof of concept code to test for this vulnerability in gitter. Thank you.

#370 is a start in the right direction. struct tag integration may be too much and out of scope. I was able to accomplish the task with the current code...