Brendan Zabarauskas comments

Results 375 comments of


                                            Brendan Zabarauskas

relative_eq() has incorrect behavior for small values

Oooh thanks for the report! I may have got something wrong in the implementation - it's been a _long_ time since I looked inside. And to be honest floating point...

Overflow on absolute comparison of signed integers

Oh huh, that's interesting. We actually implement these comparisons for integers?

Overflow on absolute comparison of signed integers

Right, seems like it's here: https://github.com/brendanzab/approx/blob/0527afee5faf712e877634ccf4b9790cac5a1d63/src/abs_diff_eq.rs#L35-L87

Automatically deriving implementations

Yeah, having this would be really nice! I know it'll be a bit annoying with the epsilon though, and haven't had much time at the moment to look into it.

Adding messages to assert_* macros

Yeah! This seems like a great idea!

Implement ApproxEq for all primitives

We should write down a list of these!

Implement ApproxEq for all primitives

Added some to the list!

Implement ApproxEq for all primitives

Hmm, yeah. Is this a problem with the API? What does approx mean for integers?

Require the epsilon value (tolerance) to be specified explicitly, and remove the default

Right! Thanks for the clarification.

Require the epsilon value (tolerance) to be specified explicitly, and remove the default

What do you think a good default epsilon would be for ulps and relative?