codespan icon indicating copy to clipboard operation
codespan copied to clipboard

examples: replace structopt with clap

Open tamird opened this issue 1 year ago • 16 comments

See https://github.com/TeXitoi/structopt/issues/525.

Currently codespan-reporting is the most downloaded dependent of structopt: https://crates.io/crates/structopt/reverse_dependencies.

tamird avatar Jan 08 '24 15:01 tamird

@Johann150 perhaps? Unclear if this repository is maintained.

tamird avatar Jan 08 '24 15:01 tamird

Please check your code formatting (or run cargo fmt), as indicated by the CI. You would probably also want to rebase on the master branch, since there unfortunately was some broken CI.

There also seems to be an issue with the minimum supported Rust version so CI will probably not completely pass still, but I don't feel qualified to change that. I'm just a collaborator, not a maintainer of this package.

Johann150 avatar Jan 08 '24 19:01 Johann150

Both issues should be fixed now. Could you trigger another run?

tamird avatar Jan 08 '24 19:01 tamird

One more attempt please! Should be fixed now. Implementing "possible values" on foreign types is a bit clumsier now.

tamird avatar Jan 08 '24 21:01 tamird

Looks like we'd need to bump MSRV to 1.56 fro 1.46 to allow this to land. See description in https://github.com/d-e-s-o/test-log/commit/9619698ef9facff2baaa450f89d9b4c4267f12d9.

tamird avatar Jan 08 '24 21:01 tamird

Would you mind allowing CI to run again?

tamird avatar Jan 09 '24 15:01 tamird

Sadly have to bump further to 1.60. Could you run CI again?

tamird avatar Jan 09 '24 18:01 tamird

Needed to update the arguments to cargo update. Another run, please!

tamird avatar Jan 09 '24 18:01 tamird

Once more please! Need 1.61.

tamird avatar Jan 09 '24 18:01 tamird

@Johann150 this is finally green. If you are not able to approve this MSRV bump, can you ping someone who is?

tamird avatar Jan 10 '24 17:01 tamird

I don't think it makes sense to raise the MSRV for the entire library just because one of the examples requires it. It would probably be a better idea to use another parsing framework, e.g. pico-args for this, or alternatively remove command line parsing from the example files and documentation code examples.

Johann150 avatar Feb 11 '24 10:02 Johann150

Done.

I added another commit to remove ColorArg, but I can withdraw it if you prefer.

tamird avatar Feb 22 '24 10:02 tamird

@Johann150 can you please run CI?

tamird avatar Feb 28 '24 11:02 tamird

@Johann150 ping.

tamird avatar Mar 14 '24 17:03 tamird

@Johann150 could you have a look please?

tamird avatar May 15 '24 15:05 tamird