Brendan Kenny
Brendan Kenny
> We don't remove metrics if they are N/A though yes, but only because there's never been a notApplicable metric before and the display code is `valueEl.textContent = audit.result.displayValue ||...
> For a faster development process you can use the --dryRun option to skip measurement and perform the interactions only > This is a multitude faster e.g. 3s vs 53s...
> Flow scripts can be arbitrarily long too. On our own flow fixtures test, dry run took the execution time from 48s to 13s (35s overhead). Since there are 4...
This still seems like a lot of infrastructure to support dry runs, adding a shadow version to every gather mode. It definitely makes any changes to the user flows API...
> This is blocking https://github.com/GoogleChrome/lighthouse/pull/14202 and removal of "isolation" from the test runner. What is the blocking part? I thought this was a reorganization for clarity of mocking/import order?
> In practice this means you can't swap locales for stack pack strings and they'll always be in en-US. Yeah, it's actually worse than this. Looks like paths are broken...
> modern-image-formats-before.trace.json (which should "match" the actual trace): > (but doesn't) I think the Lantern debug trace generator is broken (check those duration details :) The output from [`printGraph`](https://github.com/GoogleChrome/lighthouse/blob/34a7163fd2f94c157a9396eee0717e2f0a2c9d9c/lighthouse-core/computed/page-dependency-graph.js#L427) seems...
A big thing with the image audits (and almost all the ByteEfficiency audits) is that they're savings against end-of-trace, not LCP (or even TTI). It's less obvious in `https://next.webpagetest.org/themetrictimes/index.php`—in my...
Yeah, I was making a big assumption that trace emit was more broken than it was. I see the same serial image requests you did (and the trace shows), which...
agreed with @patrickhulce and with > One could argue this should be a React-specific plugin maybe we should make an issue for "Lighthouse plugin proposals/ideas" and add a React one...