amazonka icon indicating copy to clipboard operation
amazonka copied to clipboard

Should `Network.AWS.Internal.HTTP.retrier` log an error each time a request fails?

Open gridaphobe opened this issue 5 years ago • 1 comments

This is the current behavior, but it seems a bit severe. I usually try to reserve error-level logging for issues that someone needs to take a look at (generally with automated alerts). A request failing initially but succeeding later doesn't seem to rise to that level.

Perhaps it would make more sense to log only the final failure as an error, and the intermediate ones as info or warnings?

gridaphobe avatar Nov 13 '18 03:11 gridaphobe

The other thing we could do is log the retrying failures at a noisier log level, but we've gotten this far without it so let's get 2.0 out first and think about this later.

endgame avatar Oct 03 '21 06:10 endgame

#875 calls logDebug on all failures and logError on the final failure.

endgame avatar Jan 18 '23 09:01 endgame