FlameGraph icon indicating copy to clipboard operation
FlameGraph copied to clipboard

Published 20 hours ago • verified publisher icon brendangregg

Include last stack in perf collapser

Open jonhoo opened this issue 4 years ago • 3 comments

This also re-generates all the perf collapse files to account for the missing stack in each one.

r? @brendangregg

Fixes #230.

jonhoo avatar Apr 01 '20 13:04 jonhoo

Gentle ping on this @brendangregg

jonhoo avatar Apr 29 '20 16:04 jonhoo

Does perf ever emit a stack without a new line? I see it exists in the tests, but I truncated those test files by hand and I think I omitted the new line by mistake. I guess the code is harmless and already documented, it just feels odd to include code that shouldn't exist.

brendangregg avatar May 10 '20 20:05 brendangregg

I agree it's a little odd, but we had a user report that they saw output like that when using perf: https://github.com/jonhoo/inferno/issues/167. It could be that something else messed with the output, not sure, but seems worth handling this just in case anyway?

jonhoo avatar May 11 '20 13:05 jonhoo