FlameGraph icon indicating copy to clipboard operation
FlameGraph copied to clipboard

Don't drop everything after "(" inside C++ template parameters

Open adamnovak opened this issue 5 years ago • 5 comments

This should eliminate weird partial things like std::function<void from flame graphs.

Fixes #120 Fixes #192 Fixes #214

adamnovak avatar Oct 07 '19 20:10 adamnovak

Tested here at AbsInt, very useful to avoid strange cuttings for template names.

christoph-cullmann avatar Oct 11 '19 11:10 christoph-cullmann

Note: since the project doesn't have an active maintainer to address issues or even PRs, there's an active analogous project that you can use. It's written in Rust. Screenshot for a C++ testcase from this project:

Screenshot_20191127_183207

Hi-Angel avatar Nov 27 '19 15:11 Hi-Angel

I worked on this project last month. These PRs that change the regexps require a lot of testing, and I've been meaning to rewrite the testing framework before merging them. That's a lot of work but will pay off for future regexp changes.

brendangregg avatar Nov 27 '19 17:11 brendangregg

This works great for me.

pizzard avatar Dec 20 '19 18:12 pizzard

@Hi-Angel I like the much cleaner interface, however with the rust tool (v0.3.0 installed using cargo install flamegraph) I get the exact same "function<bool" partial function names.

EDIT: Now fixed in inferno v0.9.7, which should at some point be referenced in flamegraph-rs.

SoftwareApe avatar May 25 '20 09:05 SoftwareApe