Brendan Burns

Results 314 comments of Brendan Burns

This library currently uses cmake for building.

This may help, I found it using web search so I know nothing about if it works for this :) https://bazelbuild.github.io/rules_foreign_cc/main/cmake.html

I think adding a PR for this is fine. Feel free to send one. Thanks

Comments addressed. Please take another look.

@jurre please go ahead and push your commits to this branch. I will address the style/constant extraction comments after that

I actually went ahead and addressed your comments since they were so small. Please add your commits and then hopefully we can merge this!

fwiw, creating new GitHub CodeSpaces is also broken by this.

@sarwatfatimam that would be great. There are no real guidelines other than you will need to update the docs and send a pull request (PR) if you need help creating...

You need to have TCP keep alives or some small amount of TCP traffic to keep the connection alive. However, it's also worth noting that `exec` was never really meant...