generate-password icon indicating copy to clipboard operation
generate-password copied to clipboard

Clone options to innerOptions

Open manbomb opened this issue 3 years ago • 2 comments

This change prevents the methods from changing the content of the "options" object passed as a parameter.

manbomb avatar Oct 13 '21 17:10 manbomb

Is this a problem? Not sure how this could cause a bug

brendanashworth avatar Oct 13 '21 20:10 brendanashworth

This is not a problem, however, it is not good practice to change the parameters passed to a function or method, they should be immutable.

manbomb avatar Oct 14 '21 11:10 manbomb