brendan-w
Trouble code reading
Currently testing with obdsim, it appears the dtc decoder does not parse the code correctly. obdsim sends P0103 by default as you may have looked. The code obtains this as P0300. I took a look at the code. in decoders.py changing line 392 from this,
d += message.data[2:]
to this
d += message.data[1:3]
currently appears to solve the problem for the first trouble code. The fact that GET_DTC returns a list, means that it supports multiple trouble codes, but now the program returns a single one, even with multiple dtc's recieved. The change I made above may cripple the structure of the code for multiple dtc's because I did not make a detailed reading, so I add this as an issue here if it helps a solution be created.
Found out that this is caused by obdsim which does not provide DTC_Count, not even 00 in it's place. Is this behavior consistent among other vehicles ? If so, this may need to be reimplemented. checking the number of total bytes read, may solve the problem of detecting if the device provides dtc count.
After 3 trouble codes, another frame is added to the response. These frames are not parsed within the program. So none of the trouble code gets to be shown. This is caused by "Dropping frame in multi-frame response not marked as FF or CF". This behavior is observed using obdsim.
I'm a developer that made the pyobd remake, using python-obd library. Just recently we noticed that DTC is showing wrong. This is an important one for the library and my program to be of any use. Can we fix it somehow? I don't know right now how to do it, so all the help is appreciated.
I made
+= message.data[2:]
to this
d += message.data[1:3]
As previously stated now it shows the DTC correctly, but only one. Can we fix this? Thanks to every contributor.
I fixed it under pyobd. See my code to fix this python-obd library. I can't do a pull request.