archive icon indicating copy to clipboard operation
archive copied to clipboard

Published 20 hours ago • verified publisher icon brendan-duncan

Shouldn't decodeBuffer() accept an InputStreamBase instead of InputStream?

Open freemant2000 opened this issue 3 years ago • 3 comments

That would allow a InputFileStream to be passed to it without reading the whole zip file into a List of bytes.

freemant2000 avatar Apr 20 '21 08:04 freemant2000

Probably. I'll take a look at it.

brendan-duncan avatar Apr 20 '21 16:04 brendan-duncan

Can anyone provide a PR for this? I tried to look into the Code, but this issue seems too complex for me. It would help me fix unzipping very large files (1.5GB).

albatrosify avatar Aug 06 '21 08:08 albatrosify

Sorry for not getting back to this sooner. I made a branch with a rough draft of the implementation. It will probably need some more cleaning up, but if you wanted to test it, it's here: https://github.com/brendan-duncan/archive/tree/zip_input_stream_base

brendan-duncan avatar Aug 11 '21 06:08 brendan-duncan